Skip to content

Build Spring Batch Notion with Java 25 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2025
Merged

Build Spring Batch Notion with Java 25 #192

merged 2 commits into from
Nov 14, 2025
+3 −2

Conversation

@scordio
Copy link
Collaborator

@scordio scordio commented Nov 11, 2025

No description provided.

@scordio scordio force-pushed the spring-batch-notion-java-25 branch from 4a719e2 to 53e2f9d Compare November 11, 2025 15:44
@scordio
Reapply "Build Spring Batch Notion with Java 25"
c3432a8 
This reverts commit deb1c6d.

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio scordio force-pushed the spring-batch-notion-java-25 branch from 53e2f9d to c3432a8 Compare November 11, 2025 15:45
@scordio
Copy link
Collaborator Author

scordio commented Nov 11, 2025 •
edited
Loading

Javadoc generation for this line:

spring-batch-extensions/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java

Line 29 in deb1c6d

* The direction defaults to {@link Direction#DEFAULT_DIRECTION}.

fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadoc) on project spring-batch-notion: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1
[ERROR] /home/runner/work/spring-batch-extensions/spring-batch-extensions/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java:29: error: reference not found
[ERROR]  * The direction defaults to {@link Direction#DEFAULT_DIRECTION}.
[ERROR]                                     ^
[ERROR] The generated documentation contains diagnostic markers for invalid input.
[ERROR] 1 error
[ERROR] Command line was: /usr/lib/jvm/temurin-25-jdk-amd64/bin/javadoc -J-Duser.language= -J-Duser.country= @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/home/runner/work/spring-batch-extensions/spring-batch-extensions/spring-batch-notion/target/reports/apidocs' dir.

This seems to be a javadoc regression.

@scordio
Copy link
Collaborator Author

scordio commented Nov 14, 2025 •
edited
Loading

This seems to be a javadoc regression.

The javadoc failure is actually correct, because DEFAULT_DIRECTION is not a constant in the Direction enum, it's a field in the enclosing Sort class. Linking invalid references was fixed in Java 23: JDK-8164094

Related thread: https://mail.openjdk.org/pipermail/javadoc-dev/2025-November/009444.html

@scordio
Fix invalid Javadoc reference
dd460d6 
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio scordio marked this pull request as ready for review November 14, 2025 18:34
@scordio scordio merged commit 3192515 into main Nov 14, 2025
3 checks passed
@scordio scordio deleted the spring-batch-notion-java-25 branch November 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module: spring-batch-notion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scordio